fix: enhance routeCheck toggle logic#21614
Merged
auspham merged 1 commit intosonic-net:masterfrom Dec 11, 2025
Merged
Conversation
Collaborator
|
/azp run |
github-actions
bot
requested review from
Ryangwaite,
ZhaohuiS,
rawal01,
saiarcot895,
xwjiang-ms and
yejianquan
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
cyw233
force-pushed
the
further-enhance-route-check-logic
branch
from
a3c058b to
7a6880d
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
cyw233
added
Request for 202411 branch
Request for 202505 branch
Request for 202511 branch
auspham
approved these changes
Dec 10, 2025
Signed-off-by: Chenyang Wang <chenyangw233@gmail.com>
cyw233
force-pushed
the
further-enhance-route-check-logic
branch
from
7a6880d to
9a2d1dc
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
@cyw233 PR conflicts with 202511 branch |
12 tasks
echuawu
pushed a commit
to echuawu/sonic-mgmt
that referenced
this pull request
Dec 12, 2025
Signed-off-by: Chenyang Wang <chenyangw233@gmail.com>
12 tasks
Collaborator
|
Cherry-pick PR to msft-202405: Azure/sonic-mgmt.msft#931 |
Contributor
Author
|
Auto cherry pick PR has conflict. |
saravanan-nexthop
pushed a commit
to saravanan-nexthop/sonic-mgmt
that referenced
this pull request
Dec 15, 2025
Signed-off-by: Chenyang Wang <chenyangw233@gmail.com> Signed-off-by: Saravanan <saravanan@nexthop.ai>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
Signed-off-by: Chenyang Wang <chenyangw233@gmail.com> Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
Signed-off-by: Chenyang Wang <chenyangw233@gmail.com> Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
nissampa
pushed a commit
to nissampa/sonic-mgmt_dpu_test
that referenced
this pull request
Dec 16, 2025
Signed-off-by: Chenyang Wang <chenyangw233@gmail.com> Signed-off-by: Nishanth Sampath Kumar <nissampa@cisco.com>
selldinesh
pushed a commit
to selldinesh/sonic-mgmt
that referenced
this pull request
Dec 18, 2025
Signed-off-by: Chenyang Wang <chenyangw233@gmail.com> Signed-off-by: selldinesh <dinesh.sellappan@keysight.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
Signed-off-by: Chenyang Wang <chenyangw233@gmail.com> Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
Signed-off-by: Chenyang Wang <chenyangw233@gmail.com> Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
vrajeshe
pushed a commit
to Akshath-17/sonic-mgmt
that referenced
this pull request
Jan 4, 2026
Signed-off-by: Chenyang Wang <chenyangw233@gmail.com> Signed-off-by: Venkata Gouri Rajesh Etla <vrajeshe@cisco.com>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
Signed-off-by: Chenyang Wang <chenyangw233@gmail.com>
yifan-nexthop
pushed a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Jan 14, 2026
Signed-off-by: Chenyang Wang <chenyangw233@gmail.com> Signed-off-by: YiFan Wang <yifan@nexthop.ai>
PriyanshTratiya
pushed a commit
to PriyanshTratiya/sonic-mgmt
that referenced
this pull request
Jan 21, 2026
Signed-off-by: Chenyang Wang <chenyangw233@gmail.com> Signed-off-by: Priyansh Tratiya <ptratiya@microsoft.com>
lakshmi-nexthop
pushed a commit
to lakshmi-nexthop/sonic-mgmt
that referenced
this pull request
Jan 28, 2026
Signed-off-by: Chenyang Wang <chenyangw233@gmail.com> Signed-off-by: Lakshmi Yarramaneni <lakshmi@nexthop.ai>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
Signed-off-by: Chenyang Wang <chenyangw233@gmail.com> Signed-off-by: Yael Tzur <ytzur@nvidia.com>
abhishek-nexthop
pushed a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Feb 6, 2026
Signed-off-by: Chenyang Wang <chenyangw233@gmail.com>
vmittal-msft
pushed a commit
that referenced
this pull request
Feb 6, 2026
mssonicbld
added
Included in 202511 branch
and removed
Created PR to 202511 branch
labels
lakshmi-nexthop
pushed a commit
to lakshmi-nexthop/sonic-mgmt
that referenced
this pull request
Feb 11, 2026
Signed-off-by: Chenyang Wang <chenyangw233@gmail.com> Co-authored-by: Chenyang Wang <49756587+cyw233@users.noreply.github.com> Signed-off-by: Lakshmi Yarramaneni <lakshmi@nexthop.ai>
rraghav-cisco
pushed a commit
to rraghav-cisco/sonic-mgmt
that referenced
this pull request
Feb 13, 2026
Signed-off-by: Chenyang Wang <chenyangw233@gmail.com> Signed-off-by: Raghavendran Ramanathan <rraghav@cisco.com>
anilal-amd
pushed a commit
to anilal-amd/anilal-forked-sonic-mgmt
that referenced
this pull request
Feb 19, 2026
Signed-off-by: Chenyang Wang <chenyangw233@gmail.com> Signed-off-by: Zhuohui Tan <zhuohui.tan@amd.com>
abhishek-nexthop
pushed a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Mar 17, 2026
Signed-off-by: Chenyang Wang <chenyangw233@gmail.com> Signed-off-by: Abhishek <abhishek@nexthop.ai>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Mar 27, 2026
Signed-off-by: Chenyang Wang <chenyangw233@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Further enhance the routeCheck monitor disable-and-enable logic:
wait_until()timeout to verify the routeCheck status is as expected before proceeding to the next stepSummary:
Fixes # (issue) Microsoft ADO 36101536
Type of change
Back port request
Approach
What is the motivation for this PR?
This is a follow-up PR of #21582. Not all platforms need the "temporarily disable roureCheck monitor" feature, and the routeCheck monitor will take some time to startup after running
sudo monit start routeCheckon some platforms. Therefore, we want to allow the users to choose which topologies they want to apply the disable-and-enable routeCheck behavior (Now only T2, LT2 & UT2 are allowed). Besides, we added await_until()timeout to verify the routeCheck status is as expected before proceeding to the next step.How did you do it?
How did you verify/test it?
I verified it on a T0 platform and I can confirm this logic will be skipped: https://elastictest.org/scheduler/testplan/69389f2d392767e9bf67ef1a
I also verified on a T2 platform and I can confirm this logic is applied there: https://elastictest.org/scheduler/testplan/69389e7794f9e10e4c224c66
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation